-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed multi-source plane conventions and solver and added EPL velocity dispersions #287
Conversation
# Conflicts: # slsim/Deflectors/velocity_dispersion.py # slsim/lens.py # tests/test_lens.py
…l lens equation solver option
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
==========================================
- Coverage 97.86% 97.83% -0.03%
==========================================
Files 74 74
Lines 4954 4999 +45
==========================================
+ Hits 4848 4891 +43
- Misses 106 108 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sibirrer, thank you very much for this PR! It looks good to me.
Fixed a bug with the multi-source plane analytical lens equation solver, added routines to self-consistently related velocity dispersion and power-law slopes.
Also debugged a recently introduced bug on the line of sight function output interpretation